]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ACPI: SBS: Fix present test in acpi_battery_read()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 31 Oct 2025 13:03:43 +0000 (16:03 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 3 Nov 2025 16:29:52 +0000 (17:29 +0100)
commit01e11d18da818eabdb3769081e7123ed8bfe863c
tree0a2c76f16d383e3c34dc4a9e33f558e03ec5bebf
parent6146a0f1dfae5d37442a9ddcba012add260bceb0
ACPI: SBS: Fix present test in acpi_battery_read()

The battery->present variable is a 1 bit bitfield in a u8.  This means
that the "state & (1 << battery->id)" test will only work when
"battery->id" is zero, otherwise ->present is zero.  Fix this by adding
a !!.

Fixes: db1c291af7ad ("ACPI: SBS: Make SBS reads table-driven.")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aQSzr4NynN2mpEvG@stanley.mountain
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/sbs.c