]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: usb: aqc111: Do not perform PM inside suspend callback
authorNikola Z. Ivanov <zlatistiv@gmail.com>
Fri, 13 Mar 2026 14:16:43 +0000 (16:16 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 17 Mar 2026 12:36:12 +0000 (13:36 +0100)
commit069c8f5aebe4d5224cf62acc7d4b3486091c658a
tree6d4bd6fadbe0d69d8af21661404a44bc4fd29a7b
parenta0671125d4f55e1e98d9bde8a0b671941987e208
net: usb: aqc111: Do not perform PM inside suspend callback

syzbot reports "task hung in rpm_resume"

This is caused by aqc111_suspend calling
the PM variant of its write_cmd routine.

The simplified call trace looks like this:

rpm_suspend()
  usb_suspend_both() - here udev->dev.power.runtime_status == RPM_SUSPENDING
    aqc111_suspend() - called for the usb device interface
      aqc111_write32_cmd()
        usb_autopm_get_interface()
          pm_runtime_resume_and_get()
            rpm_resume() - here we call rpm_resume() on our parent
              rpm_resume() - Here we wait for a status change that will never happen.

At this point we block another task which holds
rtnl_lock and locks up the whole networking stack.

Fix this by replacing the write_cmd calls with their _nopm variants

Reported-by: syzbot+48dc1e8dfc92faf1124c@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=48dc1e8dfc92faf1124c
Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
Signed-off-by: Nikola Z. Ivanov <zlatistiv@gmail.com>
Link: https://patch.msgid.link/20260313141643.1181386-1-zlatistiv@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/usb/aqc111.c