]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: soc-compress: use function to clear symmetric params
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 19 Feb 2026 04:53:52 +0000 (04:53 +0000)
committerMark Brown <broonie@kernel.org>
Sun, 22 Feb 2026 23:52:21 +0000 (23:52 +0000)
commit07c774dd64ba0c605dbf844132122e3edbdbea93
treed9099e96e948e46c3c4cbe98e2dd98edd2fa714c
parent0fa3df83d5537c5cc3eacb9896c457f0c22791f8
ASoC: soc-compress: use function to clear symmetric params

Current soc-compress.c clears symmetric_rate, but it clears rate only,
not clear other symmetric_channels/sample_bits.

static int soc_compr_clean(...)
{
...
if (!snd_soc_dai_active(cpu_dai))
=> cpu_dai->symmetric_rate = 0;

if (!snd_soc_dai_active(codec_dai))
=> codec_dai->symmetric_rate = 0;
...
};

This feature was added when v3.7 kernel [1], and there was only
symmetric_rate, no symmetric_channels/sample_bits in that timing.

symmetric_channels/sample_bits were added in v3.14 [2],
but I guess it didn't notice that soc-compress.c is updating symmetric_xxx.

We are clearing symmetry_xxx by soc_pcm_set_dai_params(), but is soc-pcm.c
local function. Makes it global function and clear symmetry_xxx by it.

[1] commit 1245b7005de02 ("ASoC: add compress stream support")
[2] commit 3635bf09a89cf ("ASoC: soc-pcm: add symmetry for channels and
   sample bits")

Fixes: 3635bf09a89c ("ASoC: soc-pcm: add symmetry for channels and sample bits")
Cc: Nicolin Chen <b42378@freescale.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://patch.msgid.link/87ms15e3kv.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/soc.h
sound/soc/soc-compress.c
sound/soc/soc-pcm.c