]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ublk: reset per-IO canceled flag on each fetch
authorUday Shankar <ushankar@purestorage.com>
Mon, 6 Apr 2026 04:25:30 +0000 (22:25 -0600)
committerJens Axboe <axboe@kernel.dk>
Mon, 6 Apr 2026 14:37:48 +0000 (08:37 -0600)
commit0842186d2c4e67d2f8c8c2d1d779e8acffd41b5b
tree276bb018ce2fc3e069511ad52dc73d45feb070ac
parent8b155f2e4a91f3507951e6ace4b413688ac28b96
ublk: reset per-IO canceled flag on each fetch

If a ublk server starts recovering devices but dies before issuing fetch
commands for all IOs, cancellation of the fetch commands that were
successfully issued may never complete. This is because the per-IO
canceled flag can remain set even after the fetch for that IO has been
submitted - the per-IO canceled flags for all IOs in a queue are reset
together only once all IOs for that queue have been fetched. So if a
nonempty proper subset of the IOs for a queue are fetched when the ublk
server dies, the IOs in that subset will never successfully be canceled,
as their canceled flags remain set, and this prevents ublk_cancel_cmd
from actually calling io_uring_cmd_done on the commands, despite the
fact that they are outstanding.

Fix this by resetting the per-IO cancel flags immediately when each IO
is fetched instead of waiting for all IOs for the queue (which may never
happen).

Signed-off-by: Uday Shankar <ushankar@purestorage.com>
Fixes: 728cbac5fe21 ("ublk: move device reset into ublk_ch_release()")
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: zhang, the-essence-of-life <zhangweize9@gmail.com>
Link: https://patch.msgid.link/20260405-cancel-v2-1-02d711e643c2@purestorage.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c