]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
udf: fix partition descriptor append bookkeeping
authorSeohyeon Maeng <bioloidgp@gmail.com>
Tue, 10 Mar 2026 08:16:52 +0000 (17:16 +0900)
committerJan Kara <jack@suse.cz>
Thu, 19 Mar 2026 13:44:07 +0000 (14:44 +0100)
commit08841b06fa64d8edbd1a21ca6e613420c90cc4b8
treed55a73e748bd5dfed182ba9c30026511b8dd996e
parent19134a133184fcc49c41cf42797cb2e7fef76065
udf: fix partition descriptor append bookkeeping

Mounting a crafted UDF image with repeated partition descriptors can
trigger a heap out-of-bounds write in part_descs_loc[].

handle_partition_descriptor() deduplicates entries by partition number,
but appended slots never record partnum. As a result duplicate
Partition Descriptors are appended repeatedly and num_part_descs keeps
growing.

Once the table is full, the growth path still sizes the allocation from
partnum even though inserts are indexed by num_part_descs. If partnum is
already aligned to PART_DESC_ALLOC_STEP, ALIGN(partnum, step) can keep
the old capacity and the next append writes past the end of the table.

Store partnum in the appended slot and size growth from the next append
count so deduplication and capacity tracking follow the same model.

Fixes: ee4af50ca94f ("udf: Fix mounting of Win7 created UDF filesystems")
Cc: stable@vger.kernel.org
Signed-off-by: Seohyeon Maeng <bioloidgp@gmail.com>
Link: https://patch.msgid.link/20260310081652.21220-1-bioloidgp@gmail.com
Signed-off-by: Jan Kara <jack@suse.cz>
fs/udf/super.c