]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix handling of copy_file_range() return value
authorPeter Eisentraut <peter@eisentraut.org>
Mon, 29 Jun 2026 09:49:11 +0000 (11:49 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Mon, 29 Jun 2026 11:02:07 +0000 (13:02 +0200)
commit090ce6934c3442e0048192e545c05bf1c6f8d92a
tree2e6d025d17e013a00c34ae045aec6e00ad87e947
parent3dc59c1737d288dd8d5738bdb702615017098942
Fix handling of copy_file_range() return value

Treat copy_file_range() return value of zero as an error: it indicates
that no bytes could be copied (perhaps the source file is shorter than
expected), and the existing retry loop would otherwise spin forever
since nwritten would never reach BLCKSZ.

The other uses of copy_file_range() in the tree don't have this
problem.

Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Yingying Chen <cyy9255@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/3208cf7a-c7f3-41eb-92f6-33cbeff4df40%40eisentraut.org
src/bin/pg_combinebackup/reconstruct.c