]> git.ipfire.org Git - thirdparty/linux.git/commit
xfrm: xfrm_interface: require CAP_NET_ADMIN in the device netns for changelink
authorMaoyi Xie <maoyixie.tju@gmail.com>
Fri, 12 Jun 2026 08:59:41 +0000 (16:59 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 17 Jun 2026 23:01:53 +0000 (16:01 -0700)
commit095515d89b19b6cc19dfcdc846f97403ed1ebce3
treedc2aa5bfc1ee4cdec9a45fd43541d7ecf4aecb85
parente2ac3b242c37dff323a964962e43854f4b1a2b79
xfrm: xfrm_interface: require CAP_NET_ADMIN in the device netns for changelink

xfrmi_changelink() operates on at most two netns, dev_net(dev) and the
interface link netns xi->net. They differ once the device is created in
or moved to a netns other than the one the request runs in. The rtnl
changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a
caller privileged there but not in xi->net can rewrite an interface that
lives in xi->net.

Gate xfrmi_changelink() on rtnl_dev_link_net_capable() at its top,
before any attribute is parsed.

Reported-by: Xiao Liang <shaw.leon@gmail.com>
Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/
Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces")
Cc: stable@vger.kernel.org
Signed-off-by: Maoyi Xie <maoyixie.tju@gmail.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260612085941.3158249-8-maoyixie.tju@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/xfrm/xfrm_interface_core.c