]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
HID: core: Mitigate potential OOB by removing bogus memset()
authorLee Jones <lee@kernel.org>
Mon, 9 Mar 2026 14:59:29 +0000 (14:59 +0000)
committerBenjamin Tissoires <bentiss@kernel.org>
Mon, 16 Mar 2026 15:21:06 +0000 (16:21 +0100)
commit0a3fe972a7cb1404f693d6f1711f32bc1d244b1c
tree75618fe0ca043efaf4f1984d913e4bed2d7732a6
parent4bc7bc457922742d38915458e630195e761c1efd
HID: core: Mitigate potential OOB by removing bogus memset()

The memset() in hid_report_raw_event() has the good intention of
clearing out bogus data by zeroing the area from the end of the incoming
data string to the assumed end of the buffer.  However, as we have
previously seen, doing so can easily result in OOB reads and writes in
the subsequent thread of execution.

The current suggestion from one of the HID maintainers is to remove the
memset() and simply return if the incoming event buffer size is not
large enough to fill the associated report.

Suggested-by Benjamin Tissoires <bentiss@kernel.org>

Signed-off-by: Lee Jones <lee@kernel.org>
[bentiss: changed the return value]
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/hid-core.c