]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: usb-audio: us144mkii: Fix null-deref in tascam_midi_in_urb_complete()
authorŠerif Rami <ramiserifpersia@gmail.com>
Tue, 19 Aug 2025 18:51:33 +0000 (20:51 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 20 Aug 2025 05:22:23 +0000 (07:22 +0200)
commit0c5e2ae204eca74e4ccbaffc8125c3b41de9c9b8
tree6cbc1281bbb28dbed2a5597e7b980cdb8326f605
parentd9f0633867711cff87c5604a4f90daa8ab986e4f
ALSA: usb-audio: us144mkii: Fix null-deref in tascam_midi_in_urb_complete()

The smatch tool reported a potential null pointer dereference in
tascam_midi_in_urb_complete(). The 'tascam' variable, derived from
'urb->context', was checked for nullity in one place, but dereferenced
without a check in several other places.

This patch fixes the issue by adding a null check at the beginning of
the function. If 'tascam' is null, the function now safely exits.
This prevents any potential crashes from null pointer dereferences.

It also fixes a latent bug where 'usb_put_urb()' could
be called twice for the same URB on submission failure, which would
lead to a use-after-free error.

Fixes: 67afec157fe6 ("ALSA: usb-audio: us144mkii: Add MIDI support and mixer controls")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202508192109.lcMrINK1-lkp@intel.com/
Signed-off-by: Šerif Rami <ramiserifpersia@gmail.com>
Link: https://patch.msgid.link/20250819185133.10464-1-ramiserifpersia@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/usx2y/us144mkii_midi.c