]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
rtc: abx80x: Disable alarm feature if no interrupt attached
authorAnthony Pighin (Nokia) <anthony.pighin@nokia.com>
Tue, 25 Nov 2025 18:00:10 +0000 (18:00 +0000)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 12 Apr 2026 22:02:59 +0000 (00:02 +0200)
commit0fedce7244e4b85c049ce579c87e298a1b0b811d
treec4ed6d43d795850bc395903131729efd72722c70
parent30c4d2f26bb3538c328035cea2e6265c8320539e
rtc: abx80x: Disable alarm feature if no interrupt attached

Commit 795cda8338ea ("rtc: interface: Fix long-standing race when setting
alarm") exposed an issue where the rtc-abx80x driver does not clear the
alarm feature bit, but instead relies on the set_alarm operation to return
invalid.

For example, when a RTC_UIE_ON ioctl is handled, it should abort at the
feature validation. Instead, it proceeds to the rtc_timer_enqueue(),
which used to return an error from the set_alarm call. However,
following the race condition handling, which likely should not be
discarding predecing errors, a success condition is returned to the
ioctl() caller. This results in (for example):
    hwclock: select() to /dev/rtc0 to wait for clock tick timed out

Notwithstanding the validity of the race condition handling, if an interrupt
wasn't specified, or could not be attached, the driver should clear the
alarm feature bit.

Fixes: 718a820a303c ("rtc: abx80x: add alarm support")
Signed-off-by: Anthony Pighin <anthony.pighin@nokia.com>
Link: https://patch.msgid.link/BN0PR08MB69510928028C933749F4139383D1A@BN0PR08MB6951.namprd08.prod.outlook.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-abx80x.c