]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: hip04: fix RX buffer leak on build_skb failure
authorFan Wu <fanwu01@zju.edu.cn>
Sun, 12 Jul 2026 14:27:29 +0000 (14:27 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 22 Jul 2026 15:04:19 +0000 (08:04 -0700)
commit14fa65d10f5696b063a7d8d26e8291ea84a2c6ed
tree2b0567ae03d351a930fc2209c7ebeff42ba90687
parent06ec76fa534a2330fecb66deaa09be4db7ac620c
net: hip04: fix RX buffer leak on build_skb failure

When build_skb() fails in hip04_rx_poll(), the driver jumps to the
refill path without releasing the current RX buffer and its DMA mapping.
Installing a replacement buffer then overwrites the slot references and
leaks both resources.

Keep the current slot intact and return budget so NAPI retries the same
buffer.  Also free a newly allocated RX fragment when dma_map_single()
fails.

This issue was found by an in-house static analysis tool.

Fixes: 701a0fd52318 ("hip04_eth: fix missing error handle for build_skb failed")
Cc: stable@vger.kernel.org
Signed-off-by: Fan Wu <fanwu01@zju.edu.cn>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20260712142729.2057636-1-fanwu01@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hip04_eth.c