]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix argument names in pg_clear_attribute_stats() errors
authorFujii Masao <fujii@postgresql.org>
Wed, 15 Jul 2026 12:22:38 +0000 (21:22 +0900)
committerFujii Masao <fujii@postgresql.org>
Wed, 15 Jul 2026 12:25:17 +0000 (21:25 +0900)
commit173ea84dfdc96390ce37a3918aa660a15c4734a9
treec15f05e544bdeaa52e2913319d3de6fc2b80b6cb
parent928ed9b653e968ddb559a3fde7ff9a84b08f1196
Fix argument names in pg_clear_attribute_stats() errors

pg_clear_attribute_stats() checks its required arguments manually
because the function is not strict. Previously, when schemaname or
relname was passed as NULL, the error incorrectly reported the
argument name as "relation" in both cases:

    ERROR:  argument "relation" must not be null

This was misleading, especially for schemaname, and inconsistent with
the function's SQL-visible argument names.

The cause is that cleararginfo[] in attribute_stats.c used
"relation" for both the schema-name and relation-name arguments.

This commit fixes the issue by using "schemaname" and "relname" instead,
matching the function's declared argument names so that the error reports
the correct argument name.

Backpatch to v18, where pg_clear_attribute_stats() was introduced.

Author: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/4bf66c5e-8dd7-4ef3-8691-db67ecff6f16@tantorlabs.com
Backpatch-through: 18
src/backend/statistics/attribute_stats.c