]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/tilcdc: Fix irq free on unload
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tue, 19 Sep 2023 07:12:50 +0000 (10:12 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 22:52:41 +0000 (14:52 -0800)
commit1821c4d1c3c8eafb49e83054ef901b42cf750b4d
tree5307f339199b706b15a3d1176da3d8a4c87be3c8
parent08ccff6ece35f08e8107e975903c370d849089e5
drm/tilcdc: Fix irq free on unload

[ Upstream commit 38360bf96d816e175bc602c4ee76953cd303b71d ]

The driver only frees the reserved irq if priv->irq_enabled is set to
true. However, the driver mistakenly sets priv->irq_enabled to false,
instead of true, in tilcdc_irq_install(), and thus the driver never
frees the irq, causing issues on loading the driver a second time.

Fixes: b6366814fa77 ("drm/tilcdc: Convert to Linux IRQ interfaces")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230919-lcdc-v1-1-ba60da7421e1@ideasonboard.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/tilcdc/tilcdc_drv.c