]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb: rename gdbarch_software_single_step -> gdbarch_get_next_pcs
authorSimon Marchi <simon.marchi@polymtl.ca>
Thu, 14 Aug 2025 20:14:17 +0000 (16:14 -0400)
committerSimon Marchi <simon.marchi@efficios.com>
Tue, 19 Aug 2025 13:47:36 +0000 (09:47 -0400)
commit1d5f884e50590cc798fd33e9779f5d72c9d72f9c
tree89c0df8b28f0abdba6991b885a3da38f9d34ea16
parent1bf1357c6827961386ef13462aed9d41221d5911
gdb: rename gdbarch_software_single_step -> gdbarch_get_next_pcs

I spotted this while reviewing a patch adding a new
gdbarch_software_single_step implementation.  I find the name
"software_single_step" a bit misleading or unclear.  It makes it sounds
as if the function executed a single step.  In reality, this function
returns the possible next PCs for current instructions.

We have a similar concept in GDBserver:
linux_process_target::low_get_next_pcs.  I like that name, it's clear
and straight to the point.

Rename gdbarch_software_single_step to gdbarch_get_next_pcs.  I find
this name more indicative of what happens.

There is some code for ARM shared between GDB and GDBserver to implement
both sides, also called "get next pcs", so I think it all fits well
together.

Tested by rebuilding.

Change-Id: Ide74011a5034ba11117b7e7c865a093ef0b1dece
Approved-by: Kevin Buettner <kevinb@redhat.com>
Acked-by: Luis Machado <luis.machado.foss@gmail.com>
36 files changed:
gdb/aarch64-tdep.c
gdb/alpha-netbsd-tdep.c
gdb/alpha-obsd-tdep.c
gdb/alpha-tdep.c
gdb/arc-linux-tdep.c
gdb/arch-utils.c
gdb/arm-fbsd-tdep.c
gdb/arm-linux-tdep.c
gdb/arm-netbsd-tdep.c
gdb/arm-obsd-tdep.c
gdb/arm-pikeos-tdep.c
gdb/arm-wince-tdep.c
gdb/breakpoint.c
gdb/cris-tdep.c
gdb/gdbarch-gen.c
gdb/gdbarch-gen.h
gdb/gdbarch_components.py
gdb/infrun.c
gdb/linux-nat.c
gdb/loongarch-tdep.c
gdb/mips-fbsd-tdep.c
gdb/mips-linux-tdep.c
gdb/mips-netbsd-tdep.c
gdb/moxie-tdep.c
gdb/or1k-linux-tdep.c
gdb/record-full.c
gdb/riscv-fbsd-tdep.c
gdb/riscv-linux-tdep.c
gdb/rs6000-aix-tdep.c
gdb/rs6000-tdep.c
gdb/s390-tdep.c
gdb/sparc-sol2-tdep.c
gdb/sparc-tdep.c
gdb/sparc64-sol2-tdep.c
gdb/tic6x-tdep.c
gdb/z80-tdep.c