]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/ttm: fix NULL deref in ttm_bo_flush_all_fences() after fence ops detach
authorSebastian Brzezinka <sebastian.brzezinka@intel.com>
Tue, 3 Mar 2026 12:26:42 +0000 (13:26 +0100)
committerChristian König <christian.koenig@amd.com>
Thu, 5 Mar 2026 07:51:35 +0000 (08:51 +0100)
commit21613f67ede11e495281b4a6dde72cd7db3ada4e
tree99ecfdfeee1a6c9808bce6752d59dd75946edcd3
parentd2e20c8951e4bb5f4a828aed39813599980353b6
drm/ttm: fix NULL deref in ttm_bo_flush_all_fences() after fence ops detach

Since commit 541c8f2468b9 ("dma-buf: detach fence ops on signal v3"),
fence->ops may be set to NULL via RCU when a fence signals and has no
release/wait ops. ttm_bo_flush_all_fences() was not updated to handle
this and directly dereferences fence->ops->signaled, leading to a NULL
pointer dereference crash:

```
BUG: kernel NULL pointer dereference, address: 0000000000000018
RIP: 0010:ttm_bo_release+0x1bc/0x330 [ttm]
```

Since dma_fence_enable_sw_signaling() already handles the signaled case
internally (it checks DMA_FENCE_FLAG_SIGNALED_BIT before doing anything),
the ops->signaled pre-check is redundant. Simply remove it and call
dma_fence_enable_sw_signaling() unconditionally for each fence.

Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15759
Fixes: 541c8f2468b9 ("dma-buf: detach fence ops on signal v3")
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
Link: https://lore.kernel.org/r/1c2f34351b6fb70ab576aeac07987542a4d480b2.1772540459.git.sebastian.brzezinka@intel.com
drivers/gpu/drm/ttm/ttm_bo.c