]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb/testsuite: make gdb_breakpoint, runto and runto_main use parse_args
authorSimon Marchi <simon.marchi@efficios.com>
Thu, 18 Jun 2026 19:35:41 +0000 (15:35 -0400)
committerSimon Marchi <simon.marchi@efficios.com>
Fri, 19 Jun 2026 19:31:24 +0000 (15:31 -0400)
commit246aecb1cd1772ac7e5a044ffbc45d5d30ee88d1
tree64a1ccd82189db9ae6c1591c90352555c9402757
parent9011fd4bec5f84eb4fe59ae09985da01e2591b7e
gdb/testsuite: make gdb_breakpoint, runto and runto_main use parse_args

In preparation to adding an option with argument to runto, change these
procs to use parse_args to manage their args (variable arguments).
These three procs have to be converted at the same time, because they
pass args to each other.

I would have like to allow passing options mixed with non-option
arguments, to allow:

  gdb_breakpoint -qualified the_function

But that would be a larger and more difficult change, so we'll have to
stick having options after, like this:

  gdb_breakpoint the_function -qualified

Change all callers that do use options to add the leading dash.

This patch removes the "last one wins" aspect of the message/no-message
options in gdb_breakpoint and runto, but I don't think it's important.
I don't think there is actually a spot that passes both.  I added some
checks in those procs to ensure that.

Change-Id: I1500c60c4b1705ad5cd982d9324b627900ce411b
Reviewed-By: Tankut Baris Aktemur <TankutBaris.Aktemur@amd.com>
115 files changed:
gdb/testsuite/gdb.ada/break-label.exp
gdb/testsuite/gdb.ada/finish-var-size.exp
gdb/testsuite/gdb.ada/import.exp
gdb/testsuite/gdb.ada/length_cond.exp
gdb/testsuite/gdb.ada/non-ascii-utf-8.exp
gdb/testsuite/gdb.arch/aarch64-pseudo-unwind.exp
gdb/testsuite/gdb.arch/amd64-pseudo-unwind.exp
gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
gdb/testsuite/gdb.arch/arm-pseudo-unwind-legacy.exp
gdb/testsuite/gdb.arch/arm-pseudo-unwind.exp
gdb/testsuite/gdb.arch/powerpc-htm-regs.exp
gdb/testsuite/gdb.base/annotate-symlink.exp
gdb/testsuite/gdb.base/attach.exp
gdb/testsuite/gdb.base/break-inline.exp
gdb/testsuite/gdb.base/break-interp.exp
gdb/testsuite/gdb.base/condbreak-multi-context.exp
gdb/testsuite/gdb.base/dlmopen-ns-ids.exp
gdb/testsuite/gdb.base/dlmopen.exp
gdb/testsuite/gdb.base/eh_return.exp
gdb/testsuite/gdb.base/foll-exec-mode.exp
gdb/testsuite/gdb.base/foll-vfork.exp
gdb/testsuite/gdb.base/fork-no-detach-follow-child-dlopen.exp
gdb/testsuite/gdb.base/fullname.exp
gdb/testsuite/gdb.base/gdb-sigterm.exp
gdb/testsuite/gdb.base/gdb1250.exp
gdb/testsuite/gdb.base/infcall-failure-2.exp
gdb/testsuite/gdb.base/infcall-nested-structs.exp.tcl
gdb/testsuite/gdb.base/inferior-args.exp
gdb/testsuite/gdb.base/info-shared.exp
gdb/testsuite/gdb.base/jit-reader.exp
gdb/testsuite/gdb.base/nostdlib.exp
gdb/testsuite/gdb.base/prologue.exp
gdb/testsuite/gdb.base/run-attach-while-running.exp
gdb/testsuite/gdb.base/shlib-call.exp
gdb/testsuite/gdb.base/solib-bad-entry-addr.exp
gdb/testsuite/gdb.base/solib-vanish.exp
gdb/testsuite/gdb.base/stale-infcall.exp
gdb/testsuite/gdb.base/sym-file.exp
gdb/testsuite/gdb.base/symlink-sourcefile.exp
gdb/testsuite/gdb.base/tls-dlobj.exp
gdb/testsuite/gdb.base/unload.exp
gdb/testsuite/gdb.btrace/rn-dl-bind.exp
gdb/testsuite/gdb.cp/anon-ns.exp
gdb/testsuite/gdb.cp/breakpoint-shlib-func.exp
gdb/testsuite/gdb.cp/meth-typedefs.exp
gdb/testsuite/gdb.cp/nextoverthrow.exp
gdb/testsuite/gdb.cp/paramless.exp
gdb/testsuite/gdb.cp/save-bp-qualified.exp
gdb/testsuite/gdb.cp/step-and-next-inline.exp
gdb/testsuite/gdb.cp/subtypes.exp
gdb/testsuite/gdb.cp/templates.exp
gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
gdb/testsuite/gdb.dwarf2/ada-cold-name.exp
gdb/testsuite/gdb.dwarf2/ada-linkage-name.exp
gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp
gdb/testsuite/gdb.dwarf2/dw2-main-no-line-number.exp
gdb/testsuite/gdb.dwarf2/dw2-vendor-extended-opcode.exp
gdb/testsuite/gdb.dwarf2/inlined_subroutine-inheritance.exp
gdb/testsuite/gdb.dwarf2/locexpr-data-member-location.exp
gdb/testsuite/gdb.dwarf2/struct-decl.exp
gdb/testsuite/gdb.gdb/python-helper.exp
gdb/testsuite/gdb.go/methods.exp
gdb/testsuite/gdb.go/no-package.exp
gdb/testsuite/gdb.linespec/explicit.exp
gdb/testsuite/gdb.linespec/keywords.exp
gdb/testsuite/gdb.linespec/thread.exp
gdb/testsuite/gdb.multi/inferior-specific-bp.exp
gdb/testsuite/gdb.multi/multi-kill.exp
gdb/testsuite/gdb.multi/pending-bp-del-inferior.exp
gdb/testsuite/gdb.multi/pending-bp.exp
gdb/testsuite/gdb.multi/watchpoint-multi.exp
gdb/testsuite/gdb.opt/inline-break.exp
gdb/testsuite/gdb.python/py-breakpoint.exp
gdb/testsuite/gdb.python/py-events.exp
gdb/testsuite/gdb.python/py-finish-breakpoint.exp
gdb/testsuite/gdb.reverse/finish-reverse-next.exp
gdb/testsuite/gdb.reverse/func-map-to-same-line.exp
gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
gdb/testsuite/gdb.rocm/fork-exec-gpu-to-non-gpu.exp
gdb/testsuite/gdb.rocm/fork-exec-non-gpu-to-gpu.exp
gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp
gdb/testsuite/gdb.rocm/precise-memory-warning-watchpoint.exp
gdb/testsuite/gdb.rocm/precise-memory.exp
gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp
gdb/testsuite/gdb.rocm/watchpoint-basic.exp
gdb/testsuite/gdb.rust/modules.exp
gdb/testsuite/gdb.threads/del-pending-thread-bp.exp
gdb/testsuite/gdb.threads/process-dies-while-detaching.exp
gdb/testsuite/gdb.trace/actions-changed.exp
gdb/testsuite/gdb.trace/backtrace.exp
gdb/testsuite/gdb.trace/circ.exp
gdb/testsuite/gdb.trace/collection.exp
gdb/testsuite/gdb.trace/disconnected-tracing.exp
gdb/testsuite/gdb.trace/ftrace-lock.exp
gdb/testsuite/gdb.trace/ftrace.exp
gdb/testsuite/gdb.trace/infotrace.exp
gdb/testsuite/gdb.trace/packetlen.exp
gdb/testsuite/gdb.trace/passc-dyn.exp
gdb/testsuite/gdb.trace/qtro.exp
gdb/testsuite/gdb.trace/read-memory.exp
gdb/testsuite/gdb.trace/report.exp
gdb/testsuite/gdb.trace/signal.exp
gdb/testsuite/gdb.trace/status-stop.exp
gdb/testsuite/gdb.trace/strace.exp
gdb/testsuite/gdb.trace/tfind.exp
gdb/testsuite/gdb.trace/trace-break.exp
gdb/testsuite/gdb.trace/trace-condition.exp
gdb/testsuite/gdb.trace/trace-mt.exp
gdb/testsuite/gdb.trace/tstatus.exp
gdb/testsuite/gdb.trace/tsv.exp
gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp
gdb/testsuite/gdb.trace/unavailable.exp
gdb/testsuite/gdb.trace/while-dyn.exp
gdb/testsuite/lib/gdb.exp
gdb/testsuite/lib/selftest-support.exp