]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ublk: fix NULL pointer dereference in ublk_ctrl_set_size()
authorMehul Rao <mehulrao@gmail.com>
Thu, 5 Mar 2026 19:31:46 +0000 (14:31 -0500)
committerJens Axboe <axboe@kernel.dk>
Fri, 6 Mar 2026 11:25:44 +0000 (04:25 -0700)
commit25966fc097691e5c925ad080f64a2f19c5fd940a
tree30faa8e480014ca6436b5bf8c2479e70704d20c9
parentce8ee8583ed83122405eabaa8fb351be4d9dc65c
ublk: fix NULL pointer dereference in ublk_ctrl_set_size()

ublk_ctrl_set_size() unconditionally dereferences ub->ub_disk via
set_capacity_and_notify() without checking if it is NULL.

ub->ub_disk is NULL before UBLK_CMD_START_DEV completes (it is only
assigned in ublk_ctrl_start_dev()) and after UBLK_CMD_STOP_DEV runs
(ublk_detach_disk() sets it to NULL). Since the UBLK_CMD_UPDATE_SIZE
handler performs no state validation, a user can trigger a NULL pointer
dereference by sending UPDATE_SIZE to a device that has been added but
not yet started, or one that has been stopped.

Fix this by checking ub->ub_disk under ub->mutex before dereferencing
it, and returning -ENODEV if the disk is not available.

Fixes: 98b995660bff ("ublk: Add UBLK_U_CMD_UPDATE_SIZE")
Cc: stable@vger.kernel.org
Signed-off-by: Mehul Rao <mehulrao@gmail.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c