]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix incorrect declarations of variadic pg_get_*_ddl() functions.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 23 Jun 2026 19:06:34 +0000 (15:06 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 23 Jun 2026 19:06:34 +0000 (15:06 -0400)
commit2af70e9374789913c4d474e6fce2e69d7060202e
tree98123b780a94113760ad7c43bf5988c7ee493943
parent049b742daad0965be4a846035408ae27ce1f9e14
Fix incorrect declarations of variadic pg_get_*_ddl() functions.

The final parameter of an ordinary variadic function should be an
array type.  CREATE FUNCTION won't accept a declaration that isn't
like that, but it's possible to put an incorrect combination into a
pg_proc.dat entry.  Sadly, the opr_sanity test that was supposed to
check that is broken and does not report functions with non-array
final parameters.  This allowed exactly such a thinko to sneak into
the recently-added pg_get_*_ddl() functions: their last argument
should be declared text[] but was declared text.  (We'd probably
have noticed eventually, when somebody tried to actually pass a
variadic array to one of those functions.  But their regression
tests do not do that.)

Fix those functions, and fix the opr_sanity test so we'll notice
next time.  Bump catversion for new pg_proc contents.

Author: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/D41A334E-ED9E-42EE-830D-28D4D36E9317@gmail.com
doc/src/sgml/func/func-info.sgml
src/include/catalog/catversion.h
src/include/catalog/pg_proc.dat
src/test/regress/expected/opr_sanity.out
src/test/regress/sql/opr_sanity.sql