]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
zram: reject unrecognized type= values in recompress_store()
authorAndrew Stellman <astellman@stellman-greene.com>
Tue, 7 Apr 2026 15:30:27 +0000 (11:30 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 18 Apr 2026 07:10:55 +0000 (00:10 -0700)
commit2f529e73d72048743b6eaa241da6ac2bcb28099e
tree03482fb05b1c99f5321ba62d827a8a363f6a4252
parent9a8ea3c1cb251d4fc354d031e649da099140c4f4
zram: reject unrecognized type= values in recompress_store()

recompress_store() parses the type= parameter with three if statements
checking for "idle", "huge", and "huge_idle".  An unrecognized value
silently falls through with mode left at 0, causing the recompression pass
to run with no slot filter — processing all slots instead of the
intended subset.

Add a !mode check after the type parsing block to return -EINVAL for
unrecognized values, consistent with the function's other parameter
validation.

Link: https://lore.kernel.org/20260407153027.42425-1-astellman@stellman-greene.com
Signed-off-by: Andrew Stellman <astellman@stellman-greene.com>
Suggested-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/block/zram/zram_drv.c