]> git.ipfire.org Git - thirdparty/u-boot.git/commit
Revert "power: regulator: Add vin-supply for GPIO and Fixed regulators"
authorJonas Karlman <jonas@kwiboo.se>
Sat, 1 Nov 2025 20:34:26 +0000 (20:34 +0000)
committerTom Rini <trini@konsulko.com>
Thu, 6 Nov 2025 14:20:53 +0000 (08:20 -0600)
commit32ead3c1bada6501a3d34ac7c0a7088cd6bcfbd2
tree5759036a7055a295a8705d9281b7f9c7914995a6
parent854901ccd43a2f547d2bf090456214c6033144c5
Revert "power: regulator: Add vin-supply for GPIO and Fixed regulators"

Rockchip boards may depend on a working MMC regulator in SPL to
successfully load FIT payload from MMC. Typically, these boards only
include the vmmc-supply regulator and not its vin-supply in SPL control
FDT.

The commit f98d812e5353 ("power: regulator: Add vin-supply for GPIO and
Fixed regulators") breaks loading FIT from MMC in SPL on some of these
boards due to now requiring the vin-supply to be included in the SPL
control FDT.

The commit also strangely enables any found vin-supply in
regulator_common_of_to_plat() and not when a regulator is enabled or as
part of regulator_autoset().

Revert the commit to fix FIT loading in SPL on broken boards.

If a board needs to have its vin-supply enabled, two options come to
mind:

- Add regulator-always-on prop to the regulator in the -u-boot.dtsi for
  any board.

- Implement full support for reference counting of regulators and then
  update the regulator-uclass to enable any found vin-supply when a
  regulator is enabled.

This reverts commit f98d812e5353408ef77a46bad1f1cdc793ff8a03.

Reported-by: Dang Huynh <danct12@riseup.net>
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
drivers/power/regulator/regulator_common.c
drivers/power/regulator/regulator_common.h