]> git.ipfire.org Git - thirdparty/linux.git/commit
KVM: nSVM: Always intercept VMMCALL when L2 is active
authorSean Christopherson <seanjc@google.com>
Wed, 4 Mar 2026 00:22:23 +0000 (16:22 -0800)
committerSean Christopherson <seanjc@google.com>
Thu, 5 Mar 2026 00:08:56 +0000 (16:08 -0800)
commit33d3617a52f9930d22b2af59f813c2fbdefa6dd5
tree18df7732df48eb6c4e077bcb31d201233e0cd45c
parentc36991c6f8d2ab56ee67aff04e3c357f45cfc76c
KVM: nSVM: Always intercept VMMCALL when L2 is active

Always intercept VMMCALL now that KVM properly synthesizes a #UD as
appropriate, i.e. when L1 doesn't want to intercept VMMCALL, to avoid
putting L2 into an infinite #UD loop if KVM_X86_QUIRK_FIX_HYPERCALL_INSN
is enabled.

By letting L2 execute VMMCALL natively and thus #UD, for all intents and
purposes KVM morphs the VMMCALL intercept into a #UD intercept (KVM always
intercepts #UD).  When the hypercall quirk is enabled, KVM "emulates"
VMMCALL in response to the #UD by trying to fixup the opcode to the "right"
vendor, then restarts the guest, without skipping the VMMCALL.  As a
result, the guest sees an endless stream of #UDs since it's already
executing the correct vendor hypercall instruction, i.e. the emulator
doesn't anticipate that the #UD could be due to lack of interception, as
opposed to a truly undefined opcode.

Fixes: 0d945bd93511 ("KVM: SVM: Don't allow nested guest to VMMCALL into host")
Cc: stable@vger.kernel.org
Reviewed-by: Yosry Ahmed <yosry@kernel.org>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Link: https://patch.msgid.link/20260304002223.1105129-3-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/svm/hyperv.h
arch/x86/kvm/svm/nested.c