]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize
authorPuranjay Mohan <puranjay@kernel.org>
Mon, 13 Apr 2026 19:11:08 +0000 (12:11 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 15 Apr 2026 19:09:46 +0000 (12:09 -0700)
commit42f18ae53011826cfd3c84d041817e7f07bc645b
treeb706942b2270804e47d902b7d7853dc32f0f68d6
parent4fddde2a732de60bb97e3307d4eb69ac5f1d2b74
bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize

bpf_flush_icache() calls flush_icache_range() to clean the data cache
and invalidate the instruction cache for the JITed code region. However,
since commit 1dad391daef1 ("bpf, arm64: use bpf_prog_pack for memory
management"), this flush is redundant.

bpf_jit_binary_pack_finalize() copies the JITed instructions to the ROX
region via bpf_arch_text_copy() -> aarch64_insn_copy() -> __text_poke(),
and __text_poke() already calls flush_icache_range() on the written
range. The subsequent bpf_flush_icache() repeats the same cache
maintenance on an overlapping range, including an unnecessary second
synchronous IPI to all CPUs via kick_all_cpus_sync().

Remove the redundant bpf_flush_icache() call and its now-unused
definition.

Fixes: 1dad391daef1 ("bpf, arm64: use bpf_prog_pack for memory management")
Acked-by: Song Liu <song@kernel.org>
Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
Acked-by: Breno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20260413191111.3426023-2-puranjay@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
arch/arm64/net/bpf_jit_comp.c