]> git.ipfire.org Git - thirdparty/linux.git/commit
spi: s3c64xx: fix NULL-deref on driver unbind
authorJohan Hovold <johan@kernel.org>
Fri, 10 Apr 2026 09:49:25 +0000 (11:49 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 10 Apr 2026 12:45:39 +0000 (13:45 +0100)
commit45daacbead8a009844bd5dba6cfa731332184d17
treed2929181ef4807affd808259b3815ebe8500631a
parent81c9cdb110ef4a2dd653286a06ce0ae9ac05aac1
spi: s3c64xx: fix NULL-deref on driver unbind

A change moving DMA channel allocation from probe() back to
s3c64xx_spi_prepare_transfer() failed to remove the corresponding
deallocation from remove().

Drop the bogus DMA channel release from remove() to avoid triggering a
NULL-pointer dereference on driver unbind.

This issue was flagged by Sashiko when reviewing a controller
deregistration fix.

Fixes: f52b03c70744 ("spi: s3c64xx: requests spi-dma channel only during data transfer")
Cc: stable@vger.kernel.org # 6.0
Cc: Adithya K V <adithya.kv@samsung.com>
Link: https://sashiko.dev/#/patchset/20260410081757.503099-1-johan%40kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260410094925.518343-1-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-s3c64xx.c