]> git.ipfire.org Git - thirdparty/linux.git/commit
pinctrl: qcom: ipq9650: fix audio_sec_mclk_in1/out1 group pins
authorTaceddin Sancak <ts.solidarity@gmail.com>
Sat, 18 Jul 2026 00:21:46 +0000 (03:21 +0300)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Mon, 27 Jul 2026 14:48:20 +0000 (16:48 +0200)
commit4a2e2c563b0ee2253a7902f775bf71232820186d
tree5107fad0be37cd441771872feeb586fd7e26365a
parent437a8d2aa1aa442c4a176fdf4700a9b3bb0c8794
pinctrl: qcom: ipq9650: fix audio_sec_mclk_in1/out1 group pins

The audio_sec_mclk_in1 and audio_sec_mclk_out1 groups both list
"gpio37", but in the pingroup table those functions are muxed on
gpio39, while gpio37 provides the audio_sec_mclk_in0/out0 variants.
This makes both functions unusable: selecting them on gpio39 is
rejected by the pinmux core because the group is not listed for the
function, and selecting them on gpio37 trips the WARN_ON() in
msm_pinmux_set_mux() and fails with -EINVAL because that group
cannot mux them.

Point both groups at gpio39, matching the pingroup table. This also
mirrors the primary audio MCLK pair, where the mclk0 and mclk1
variants live on separate pins (gpio53 and gpio51 respectively).

Fixes: 3c8e7ba0e399 ("pinctrl: qcom: Introduce IPQ9650 TLMM driver")
Assisted-by: Claude:claude-fable-5
Signed-off-by: Taceddin Sancak <ts.solidarity@gmail.com>
Acked-by: Linus Walleij <linusw@kernel.org>
Reviewed-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://patch.msgid.link/20260718002146.698973-1-ts.solidarity@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/pinctrl/qcom/pinctrl-ipq9650.c