]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Only use memory-backend-file with NUMA if needed
authorMartin Kletzander <mkletzan@redhat.com>
Fri, 23 Sep 2016 09:31:30 +0000 (11:31 +0200)
committerMartin Kletzander <mkletzan@redhat.com>
Tue, 4 Oct 2016 06:38:55 +0000 (08:38 +0200)
commit4c052baf46e73c631aea98f0c4581bc6f74c33d9
tree7ac64fb09723a0e78ed156d3be3e60215845c43b
parent255f35e12478c0c72c10a6c5bc4e8b4995e2036b
qemu: Only use memory-backend-file with NUMA if needed

If this reminds you of a commit message from around a year ago, it's
41c2aa729f0af084ede95ee9a06219a2dd5fb5df and yes, we're dealing with
"the same thing" again.  Or f309db1f4d51009bad0d32e12efc75530b66836b and
it's similar.

There is a logic in place that if there is no real need for
memory-backend-file, qemuBuildMemoryBackendStr() returns 0.  However
that wasn't the case with hugepage backing.  The reason for that was
that we abused the 'pagesize' variable for storing that information, but
we should rather have a separate one that specifies whether we really
need the new object for hugepage backing.  And that variable should be
set only if this particular NUMA cell needs special treatment WRT
hugepages.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1372153

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
(cherry picked from commit 4372a7845acbc6974f6027ef68e7dd3eeb47f425)
src/qemu/qemu_command.c
tests/qemuxml2argvdata/qemuxml2argv-hugepages-pages2.args