]> git.ipfire.org Git - thirdparty/linux.git/commit
fuse: reject oversized dirents in page cache
authorSamuel Page <sam@bynar.io>
Mon, 20 Apr 2026 09:01:37 +0000 (11:01 +0200)
committerChristian Brauner <brauner@kernel.org>
Thu, 23 Apr 2026 22:34:58 +0000 (00:34 +0200)
commit51a8de6c50bf947c8f534cd73da4c8f0a13e7bed
treed8ad8104d3902813f3c27fa1dd9f6cb7e5dc09f9
parent6689f01d6740cf358932b3e97ee968c6099800d9
fuse: reject oversized dirents in page cache

fuse_add_dirent_to_cache() computes a serialized dirent size from the
server-controlled namelen field and copies the dirent into a single
page-cache page. The existing logic only checks whether the dirent fits
in the remaining space of the current page and advances to a fresh page
if not. It never checks whether the dirent itself exceeds PAGE_SIZE.

As a result, a malicious FUSE server can return a dirent with
namelen=4095, producing a serialized record size of 4120 bytes. On 4 KiB
page systems this causes memcpy() to overflow the cache page by 24 bytes
into the following kernel page.

Reject dirents that cannot fit in a single page before copying them into
the readdir cache.

Fixes: 69e34551152a ("fuse: allow caching readdir")
Cc: stable@vger.kernel.org # v6.16+
Assisted-by: Bynario AI
Signed-off-by: Samuel Page <sam@bynar.io>
Reported-by: Qi Tang <tpluszz77@gmail.com>
Reported-by: Zijun Hu <nightu@northwestern.edu>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Link: https://patch.msgid.link/20260420090139.662772-1-mszeredi@redhat.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/fuse/readdir.c