]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_stat_statements: fetch stmt location/length before it disappears.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 1 Nov 2022 16:48:01 +0000 (12:48 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 1 Nov 2022 16:48:01 +0000 (12:48 -0400)
commit56083ff3015b1beadb72724d3b9ddac81f69453c
tree7ef53b0622eda6d61c2582fb1e4ffd47b4224bb3
parentb02fc7df193b2c71f359cc2b42e21515311ab188
pg_stat_statements: fetch stmt location/length before it disappears.

When executing a utility statement, we must fetch everything
we need out of the PlannedStmt data structure before calling
standard_ProcessUtility.  In certain cases (possibly only ROLLBACK
in extended query protocol), that data structure will get freed
during command execution.  The situation is probably often harmless
in production builds, but in debug builds we intentionally overwrite
the freed memory with garbage, leading to picking up garbage values
of statement location and length, typically causing an assertion
failure later in pg_stat_statements.  In non-debug builds, if
something did go wrong it would likely lead to storing garbage
for the query string.

Report and fix by zhaoqigui (with cosmetic adjustments by me).
It's an old problem, so back-patch to all supported versions.

Discussion: https://postgr.es/m/17663-a344fd0675f92128@postgresql.org
Discussion: https://postgr.es/m/1667307420050.56657@hundsun.com
contrib/pg_stat_statements/pg_stat_statements.c