]> git.ipfire.org Git - thirdparty/linux.git/commit
firmware: google: framebuffer: Do not unregister platform device
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 17 Feb 2026 15:56:11 +0000 (16:56 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 20 Feb 2026 13:38:17 +0000 (14:38 +0100)
commit5cd28bd28c8ce426b56ce4230dbd17537181d5ad
treecec09a7ef20f35ff8343e0d9817b7d8b2fe51c1b
parent948e195dfaa56e48eabda591f97630502ff7e27e
firmware: google: framebuffer: Do not unregister platform device

The native driver takes over the framebuffer aperture by removing the
system- framebuffer platform device. Afterwards the pointer in drvdata
is dangling. Remove the entire logic around drvdata and let the kernel's
aperture helpers handle this. The platform device depends on the native
hardware device instead of the coreboot device anyway.

When commit 851b4c14532d ("firmware: coreboot: Add coreboot framebuffer
driver") added the coreboot framebuffer code, the kernel did not support
device-based aperture management. Instead native driviers only removed
the conflicting fbdev device. At that point, unregistering the framebuffer
device most likely worked correctly. It was definitely broken after
commit d9702b2a2171 ("fbdev/simplefb: Do not use struct
fb_info.apertures"). So take this commit for the Fixes tag. Earlier
releases might work depending on the native hardware driver.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: d9702b2a2171 ("fbdev/simplefb: Do not use struct fb_info.apertures")
Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>
Acked-by: Julius Werner <jwerner@chromium.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Hans de Goede <hansg@kernel.org>
Cc: linux-fbdev@vger.kernel.org
Cc: <stable@vger.kernel.org> # v6.3+
Link: https://patch.msgid.link/20260217155836.96267-2-tzimmermann@suse.de
drivers/firmware/google/framebuffer-coreboot.c