]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
spi: cadence-qspi: Revert the filtering of certain opcodes in ODTR
authorMiquel Raynal <miquel.raynal@bootlin.com>
Fri, 10 Apr 2026 17:41:01 +0000 (19:41 +0200)
committerMark Brown <broonie@kernel.org>
Sat, 11 Apr 2026 10:53:53 +0000 (11:53 +0100)
commit5e75c1d4d386fb7d64e2b19355e4d38dd4fd8845
treecf3d8641bfc4b162b8daeaf80ec94aadec10801b
parentab00febad191d7a4400aa1c3468279fb508258d4
spi: cadence-qspi: Revert the filtering of certain opcodes in ODTR

I got mislead while analyzing the driver by the fact that the second
opcode byte was in all cases smashed:

        if (op->cmd.dtr)
                opcode = op->cmd.opcode >> 8;
        else
                opcode = op->cmd.opcode;

While at a first glance this doesn't let a chance to the second byte to
be shifted out on the bus, this is actually the second step of an
initialization, where the byte being apparently "ignored" in DTR mode
has already been written in a dedicated "extended opcode" register. As
such, the comment and the extra check that I proposed were entirely
wrong, remove them.

Fixes: bee085476d27 ("spi: cadence-qspi: Make sure we filter out unsupported ops")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://patch.msgid.link/20260410-winbond-6-19-rc1-oddr-v1-1-2ac4827a3868@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence-quadspi.c