]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix replica identity check for INSERT ON CONFLICT DO UPDATE.
authorDean Rasheed <dean.a.rasheed@gmail.com>
Thu, 4 Sep 2025 10:36:25 +0000 (11:36 +0100)
committerDean Rasheed <dean.a.rasheed@gmail.com>
Thu, 4 Sep 2025 10:36:25 +0000 (11:36 +0100)
commit5fd569ef2d621d3a36d69b6ceb669866014db39d
tree0ea825335735511f9bc886fe35c2fcf9fe2271ac
parent160ef51c8dbab47b04c5aa65b6909e7be5ec5af6
Fix replica identity check for INSERT ON CONFLICT DO UPDATE.

If an INSERT has an ON CONFLICT DO UPDATE clause, the executor must
check that the target relation supports UPDATE as well as INSERT. In
particular, it must check that the target relation has a REPLICA
IDENTITY if it publishes updates. Formerly, it was not doing this
check, which could lead to silently breaking replication.

Fix by adding such a check to CheckValidResultRel(), which requires
adding a new onConflictAction argument. In back-branches, preserve ABI
compatibility by introducing a wrapper function with the original
signature.

Author: Zhijie Hou <houzj.fnst@fujitsu.com>
Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com>
Tested-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/OS3PR01MB57180C87E43A679A730482DF94B62@OS3PR01MB5718.jpnprd01.prod.outlook.com
Backpatch-through: 13
src/backend/executor/execMain.c
src/backend/executor/execPartition.c
src/backend/executor/nodeModifyTable.c
src/include/executor/executor.h
src/test/regress/expected/publication.out
src/test/regress/sql/publication.sql