]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: hamradio: bpqether: validate frame length in bpq_rcv()
authorMashiro Chen <mashiro.chen@mailbox.org>
Thu, 9 Apr 2026 02:49:26 +0000 (10:49 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sun, 12 Apr 2026 20:19:03 +0000 (13:19 -0700)
commit6183bd8723a3eecd2d89cbc506fe938bc6288345
tree0bfb381296b72f830892f619ae63336166c4f7b6
parent2835750dd6475a5ddc116be0b4c81fee8ce1a902
net: hamradio: bpqether: validate frame length in bpq_rcv()

The BPQ length field is decoded as:

  len = skb->data[0] + skb->data[1] * 256 - 5;

If the sender sets bytes [0..1] to values whose combined value is
less than 5, len becomes negative.  Passing a negative int to
skb_trim() silently converts to a huge unsigned value, causing the
function to be a no-op.  The frame is then passed up to AX.25 with
its original (untrimmed) payload, delivering garbage beyond the
declared frame boundary.

Additionally, a negative len corrupts the 64-bit rx_bytes counter
through implicit sign-extension.

Add a bounds check before pulling the length bytes: reject frames
where len is negative or exceeds the remaining skb data.

Acked-by: Joerg Reuter <jreuter@yaina.de>
Signed-off-by: Mashiro Chen <mashiro.chen@mailbox.org>
Link: https://patch.msgid.link/20260409024927.24397-2-mashiro.chen@mailbox.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/hamradio/bpqether.c