]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/vc4: Shut down BO cache timer before teardown
authorLinmao Li <lilinmao@kylinos.cn>
Mon, 20 Jul 2026 08:44:26 +0000 (16:44 +0800)
committerMaíra Canal <mcanal@igalia.com>
Thu, 23 Jul 2026 23:07:23 +0000 (20:07 -0300)
commit6273dd3ffb54ec581855b82ae77331b66028249c
tree8b9234294c14a454af2c887fa70bc8bfe55a25c6
parentb04a248cfa6cfa1e7dc9ce91cb1eb88b1a70dd69
drm/vc4: Shut down BO cache timer before teardown

The BO cache timer callback schedules time_work, and time_work can rearm
the timer through vc4_bo_cache_free_old().

vc4_bo_cache_destroy() deletes the timer and then cancels the work, which
does not break that cycle: the work being cancelled can rearm the timer,
and the timer then queues work again after teardown.

Use timer_shutdown_sync() instead, so the timer cannot be rearmed and the
cycle ends with cancel_work_sync().

Fixes: c826a6e10644 ("drm/vc4: Add a BO cache.")
Cc: stable@vger.kernel.org
Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
Link: https://patch.msgid.link/20260720084426.1632508-1-lilinmao@kylinos.cn
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Maíra Canal <mcanal@igalia.com>
drivers/gpu/drm/vc4/vc4_bo.c