]> git.ipfire.org Git - thirdparty/apache/httpd.git/commit
Fix a double-free condition when byterange requests are made on brigades
authorCliff Woolley <jwoolley@apache.org>
Fri, 24 Aug 2001 20:27:40 +0000 (20:27 +0000)
committerCliff Woolley <jwoolley@apache.org>
Fri, 24 Aug 2001 20:27:40 +0000 (20:27 +0000)
commit64dd7641e71b31bc1c3bcfea12c4dfbecf367ae2
tree2ea56a30b1902c4275bafc6a4a53ae3809b1bd00
parentbb757df043f8d7a3909e2f35e8f39b4b49b70f47
Fix a double-free condition when byterange requests are made on brigades
containing any bucket that cannot be copied natively (ie, pipe or socket
buckets).

Before, we were reading that bucket to morph it to a heap bucket and then
taking the str that heap bucket points to and placing it in a second,
completely separate heap bucket.  That means we'd have two apr_bucket/
apr_bucket_heap pairs each with a refcount of 1 (rather than two apr_buckets
and a single apr_bucket_heap with a refcount of 2).  str would then be
doubly-freed when the second of those two buckets was destroyed.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90648 13f79535-47bb-0310-9956-ffa450edef68
modules/http/http_protocol.c