]> git.ipfire.org Git - thirdparty/linux.git/commit
ata: sata_dwc_460ex: fix clear_interrupt_bit() clearing all pending interrupts
authorRosen Penev <rosenp@gmail.com>
Sun, 12 Jul 2026 21:37:27 +0000 (14:37 -0700)
committerDamien Le Moal <dlemoal@kernel.org>
Mon, 13 Jul 2026 05:32:11 +0000 (14:32 +0900)
commit66c4e310ad71f41e41736d33dd8a1fb5eaaec7f3
treed6f2ea56c9a12ddd178009ac6f2755cb0c609a82
parenta4af122106f73ea510bb35a9ea1dedd980fc0db7
ata: sata_dwc_460ex: fix clear_interrupt_bit() clearing all pending interrupts

clear_interrupt_bit() ignores the bit argument and performs a
read-write-back of the entire INTPR register.  If INTPR uses standard
Write-1-to-Clear semantics, this clears every pending interrupt bit,
not just the intended one.  Coalesced interrupts (e.g. DMAT + NEWFP)
would be cleared together, silently losing the second event.

Write only the specific bit to clear so that other pending interrupts
are preserved.

Fixes: 62936009f35a ("[libata] Add 460EX on-chip SATA driver, sata_dwc_460ex")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
drivers/ata/sata_dwc_460ex.c