]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: hot-plug: Fix broken SCSI disk hot-plug
authorMarc Hartmayer <mhartmay@linux.vnet.ibm.com>
Mon, 27 Jun 2016 14:43:46 +0000 (16:43 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 30 Jun 2016 11:36:50 +0000 (13:36 +0200)
commit696ab0a1256a2c6a726005e30ea9f1ee4536334e
tree86668ebdb4a6c710e3ce1093e7aef0b8fb93aaa9
parent881441f84a30cd3921df313a982f7162d7ca04f4
qemu: hot-plug: Fix broken SCSI disk hot-plug

The commit "qemu: hot-plug: Assume support for -device in
qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI
controller creation used in SCSI disk hot-plugging. If we are
hot-plugging a SCSI disk to a domain and there is no proper SCSI
controller defined, it results in an "error: internal error: Could not
find scsi controller with index X required for device" error.

For that reason reverting a hunk of the commit
d4d32005d6e8b2cc0a2f26b483ca1de10171db6d.

This patch also adds an extra comment to the code to clarify the
loop.

Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>
Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
(cherry picked from commit 58d07db9b0c294e92e294cadd737eee8597bf747)
src/qemu/qemu_hotplug.c