]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Be more wary about NULL values for GUC string variables.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 2 Nov 2023 15:47:33 +0000 (11:47 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 2 Nov 2023 15:47:33 +0000 (11:47 -0400)
commit6e1cca5113487bb9ef4daa1bb2833c6333466410
tree1fb280c892f1f99c8bebd83da048349941883d63
parentf8b96c211da0037269e31bd2be5e0f730ec5a2bc
Be more wary about NULL values for GUC string variables.

get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN
has a NULL boot_val.  Nosing around found a couple of other places
that seemed insufficiently cautious about NULL string values, although
those are likely unreachable in practice.  Add some commentary
defining the expectations for NULL values of string variables,
in hopes of forestalling future additions of more such bugs.

Xing Guo, Aleksander Alekseev, Tom Lane

Discussion: https://postgr.es/m/CACpMh+AyDx5YUpPaAgzVwC1d8zfOL4JoD-uyFDnNSa1z0EsDQQ@mail.gmail.com
src/backend/utils/misc/guc.c
src/include/utils/guc_tables.h