]> git.ipfire.org Git - thirdparty/shadow.git/commit
src/usermod.c: update_gshadow_file(): Fix RESOURCE_LEAK (CWE-772)
authorAlejandro Colomar <alx@kernel.org>
Fri, 17 May 2024 00:15:15 +0000 (02:15 +0200)
committerIker Pedrosa <ikerpedrosam@gmail.com>
Mon, 20 May 2024 07:37:01 +0000 (09:37 +0200)
commit71a3238b7996285fc3c8dec841244ba95d663fa5
tree035567fc5af8e59e774220550322ade00791fab1
parent61964aa06b9e6e0643a6519f64290f18ac04867f
src/usermod.c: update_gshadow_file(): Fix RESOURCE_LEAK (CWE-772)

Report:
> shadow-4.15.0/src/usermod.c:864:3: alloc_fn: Storage is returned from allocation function "__sgr_dup".
> shadow-4.15.0/src/usermod.c:864:3: var_assign: Assigning: "nsgrp" = storage returned from "__sgr_dup(sgrp)".
> shadow-4.15.0/src/usermod.c:964:1: leaked_storage: Variable "nsgrp" going out of scope leaks the storage it points to.
> 962|                   free (nsgrp);
> 963|           }
> 964|-> }
> 965|   #endif                                /* SHADOWGRP */
> 966|

Link: https://issues.redhat.com/browse/RHEL-35383
Reported-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
src/usermod.c