]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/radeon: Remove calls to drm_put_dev()
authorDaniel Palmer <daniel@0x0f.com>
Sat, 18 Oct 2025 05:44:51 +0000 (14:44 +0900)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 28 Oct 2025 15:00:08 +0000 (11:00 -0400)
commit745bae76acdd71709773c129a69deca01036250b
tree9768a46656177142a017162f7fe293441410a32b
parent3328443363a0895fd9c096edfe8ecd372ca9145e
drm/radeon: Remove calls to drm_put_dev()

Since the allocation of the drivers main structure was changed to
devm_drm_dev_alloc() drm_put_dev()'ing to trigger it to be free'd
should be done by devres.

However, drm_put_dev() is still in the probe error and device remove
paths. When the driver fails to probe warnings like the following are
shown because devres is trying to drm_put_dev() after the driver
already did it.

[    5.642230] radeon 0000:01:05.0: probe with driver radeon failed with error -22
[    5.649605] ------------[ cut here ]------------
[    5.649607] refcount_t: underflow; use-after-free.
[    5.649620] WARNING: CPU: 0 PID: 357 at lib/refcount.c:28 refcount_warn_saturate+0xbe/0x110

Fixes: a9ed2f052c5c ("drm/radeon: change drm_dev_alloc to devm_drm_dev_alloc")
Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 3eb8c0b4c091da0a623ade0d3ee7aa4a93df1ea4)
drivers/gpu/drm/radeon/radeon_drv.c