]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
cgroup/dmem: Return -ENOMEM on failed pool preallocation
authorGuopeng Zhang <zhangguopeng@kylinos.cn>
Mon, 11 May 2026 01:31:50 +0000 (09:31 +0800)
committerTejun Heo <tj@kernel.org>
Mon, 11 May 2026 01:43:46 +0000 (15:43 -1000)
commit796ad622040f7f955ccc3973085e953415920496
treed437f8d5a0ccee90407af6aad7254f205a306f12
parentdde2f938d02f2c740d49bb5113dea941f941026a
cgroup/dmem: Return -ENOMEM on failed pool preallocation

get_cg_pool_unlocked() handles allocation failures under dmemcg_lock by
dropping the lock, preallocating a pool with GFP_KERNEL, and retrying the
locked lookup and creation path.

If the fallback allocation fails too, pool remains NULL. Since the loop
condition is while (!pool), the function can keep retrying instead of
propagating the allocation failure to the caller.

Set pool to ERR_PTR(-ENOMEM) when the fallback allocation fails so the
loop exits through the existing common return path. The callers already
handle ERR_PTR() from get_cg_pool_unlocked(), so this restores the
expected error path.

Fixes: b168ed458dde ("kernel/cgroup: Add "dmem" memory accounting cgroup")
Cc: stable@vger.kernel.org # v6.14+
Signed-off-by: Guopeng Zhang <zhangguopeng@kylinos.cn>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup/dmem.c