]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
backlight: sky81452-backlight: Check return value of devm_gpiod_get_optional() in...
authorChen Ni <nichen@iscas.ac.cn>
Tue, 3 Feb 2026 02:16:25 +0000 (10:16 +0800)
committerLee Jones <lee@kernel.org>
Fri, 6 Mar 2026 14:21:07 +0000 (14:21 +0000)
commit797cc011ae02bda26f93d25a4442d7a1a77d84df
tree7eb7a70181818b3d2908eb41a1dfef793e6496a8
parent6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
backlight: sky81452-backlight: Check return value of devm_gpiod_get_optional() in sky81452_bl_parse_dt()

The devm_gpiod_get_optional() function may return an ERR_PTR in case of
genuine GPIO acquisition errors, not just NULL which indicates the
legitimate absence of an optional GPIO.

Add an IS_ERR() check after the call in sky81452_bl_parse_dt(). On
error, return the error code to ensure proper failure handling rather
than proceeding with invalid pointers.

Fixes: e1915eec54a6 ("backlight: sky81452: Convert to GPIO descriptors")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Link: https://patch.msgid.link/20260203021625.578678-1-nichen@iscas.ac.cn
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/video/backlight/sky81452-backlight.c