]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bpf: Check validity of link->type in bpf_link_show_fdinfo()
authorHou Tao <houtao1@huawei.com>
Fri, 27 Dec 2024 06:04:35 +0000 (14:04 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2025 12:24:59 +0000 (13:24 +0100)
commit79f87a6ec39fb5968049a6775a528bf58b25c20a
tree963a0449b554428ecd148ea655779007a1200d65
parent1504108cb6020df7b1a31c9bb80fd587470aa448
bpf: Check validity of link->type in bpf_link_show_fdinfo()

commit 8421d4c8762bd022cb491f2f0f7019ef51b4f0a7 upstream.

If a newly-added link type doesn't invoke BPF_LINK_TYPE(), accessing
bpf_link_type_strs[link->type] may result in an out-of-bounds access.

To spot such missed invocations early in the future, checking the
validity of link->type in bpf_link_show_fdinfo() and emitting a warning
when such invocations are missed.

Signed-off-by: Hou Tao <houtao1@huawei.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20241024013558.1135167-3-houtao@huaweicloud.com
[ shung-hsi.yu: break up existing seq_printf() call since commit 68b04864ca42
  ("bpf: Create links for BPF struct_ops maps.") is not present ]
Signed-off-by: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/bpf/syscall.c