]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: fixup error handling in fixup_inode_link_counts
authorJosef Bacik <josef@toxicpanda.com>
Wed, 19 May 2021 17:13:15 +0000 (13:13 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Jun 2021 10:42:37 +0000 (12:42 +0200)
commit7a7ccd02dcb9f09550f95e9d697c31af35d1a60b
tree6a147b20ed6cf9b656082433b51dd77ec731ae42
parent247dcb0f56753a45e280592a24fd86b12200d5d8
btrfs: fixup error handling in fixup_inode_link_counts

commit 011b28acf940eb61c000059dd9e2cfcbf52ed96b upstream.

This function has the following pattern

while (1) {
ret = whatever();
if (ret)
goto out;
}
ret = 0
out:
return ret;

However several places in this while loop we simply break; when there's
a problem, thus clearing the return value, and in one case we do a
return -EIO, and leak the memory for the path.

Fix this by re-arranging the loop to deal with ret == 1 coming from
btrfs_search_slot, and then simply delete the

ret = 0;
out:

bit so everybody can break if there is an error, which will allow for
proper error handling to occur.

CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/tree-log.c