]> git.ipfire.org Git - thirdparty/systemd.git/commit
Revert "fs-util: include fcntl.h in fs-util.h"
authorMike Yuan <me@yhndnzj.com>
Wed, 25 Jun 2025 11:04:47 +0000 (13:04 +0200)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Wed, 25 Jun 2025 15:46:20 +0000 (00:46 +0900)
commit7c3da8cbf9e398578dfc26628a4bc323abf55415
tree000b7a4bc3196a6f3329a41c598fb9b8c1d1e177
parentf8b598d381c2f63511c9114a751614904c29a5b7
Revert "fs-util: include fcntl.h in fs-util.h"

This reverts commit 4d0fe93cbaf01fcc2a61f51bb36cd4b07394bab8.

I'm not convinced by the reasoning here. The practice of
forward declarations should be confined in headers only,
and any actual invocation of functions in source files
needs to include the original header. strv_split_full()
for instance takes ExtractFlags, and callers will need
to include extract-word.h to get the value definitions.

Now, indeed some -util headers export the most relevant
system header too, notably pidfd-util. But fs-util doesn't
seem to be coupled with any specific header, hence I'm
skeptical about such inclusion.
src/basic/fs-util.h