]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
nvmet-tcp: check return value of nvmet_tcp_set_queue_sock
authorGeliang Tang <tanggeliang@kylinos.cn>
Tue, 26 May 2026 09:28:05 +0000 (17:28 +0800)
committerKeith Busch <kbusch@kernel.org>
Wed, 27 May 2026 14:50:27 +0000 (07:50 -0700)
commit7ef789703e2b91775dcb36b2efa46325be31a2a0
tree7d05582596314699ebc637c6f93a83b47b7fce4e
parent4dae393956093c807212918fd91a8fc70df15338
nvmet-tcp: check return value of nvmet_tcp_set_queue_sock

The return value of nvmet_tcp_set_queue_sock() is currently ignored in
nvmet_tcp_tls_handshake_done(). If it fails (e.g., due to the socket
not being in TCP_ESTABLISHED state), the socket callbacks will not be
properly set, leading to queue and socket leakage.

Fix this by capturing the return value and calling
nvmet_tcp_schedule_release_queue() on failure to ensure proper cleanup.

Fixes: 675b453e0241 ("nvmet-tcp: enable TLS handshake upcall")
Reviewed-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/tcp.c