]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
xfrm: fix refcount leak in xfrm_migrate_policy_find
authorKotlyarov Mihail <mihailkotlyarow@gmail.com>
Sat, 4 Apr 2026 09:05:20 +0000 (12:05 +0300)
committerSteffen Klassert <steffen.klassert@secunet.com>
Tue, 7 Apr 2026 08:24:23 +0000 (10:24 +0200)
commit83317cce60a032c49480dcdabe146435bd689d03
tree8f5467464feb541b26f3cb1b8978e1eef6661dd7
parent1c428b03840094410c5fb6a5db30640486bbbfcb
xfrm: fix refcount leak in xfrm_migrate_policy_find

syzkaller reported a memory leak in xfrm_policy_alloc:

  BUG: memory leak
  unreferenced object 0xffff888114d79000 (size 1024):
    comm "syz.1.17", pid 931
    ...
    xfrm_policy_alloc+0xb3/0x4b0 net/xfrm/xfrm_policy.c:432

The root cause is a double call to xfrm_pol_hold_rcu() in
xfrm_migrate_policy_find(). The lookup function already returns
a policy with held reference, making the second call redundant.

Remove the redundant xfrm_pol_hold_rcu() call to fix the refcount
imbalance and prevent the memory leak.

Found by Linux Verification Center (linuxtesting.org) with Syzkaller.

Fixes: 563d5ca93e88 ("xfrm: switch migrate to xfrm_policy_lookup_bytype")
Signed-off-by: Kotlyarov Mihail <mihailkotlyarow@gmail.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_policy.c