]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
fbcon: Use correct type for vc_resize() return value
authorJiacheng Yu <yujiacheng3@huawei.com>
Thu, 14 May 2026 09:19:18 +0000 (17:19 +0800)
committerHelge Deller <deller@gmx.de>
Sun, 7 Jun 2026 16:25:42 +0000 (18:25 +0200)
commit84202754fb1727dc3ee87f47104e4162ecc8ba3a
treefcda4a67b34bcfde7600ad46c0b4d5402465e228
parente840a232a4a017ff61faedf715083fa1785dfde7
fbcon: Use correct type for vc_resize() return value

The return value of vc_resize() is int, but fbcon_set_disp() stores it
in an unsigned long variable. While the !ret check happens to work
correctly by coincidence (negative values become large positive values),
the types should match. Use int instead.

Eliminates the following W=3 warning:

  drivers/video/fbdev/core/fbcon.c: In function 'fbcon_set_disp':
  drivers/video/fbdev/core/fbcon.c:1494:14: warning: implicit conversion from 'int' to 'unsigned long' [-Wconversion]

Fixes: af0db3c1f898 ("fbdev: Fix vmalloc out-of-bounds write in fast_imageblit")
Cc: stable@vger.kernel.org # v6.17+
Signed-off-by: Jiacheng Yu <yujiacheng3@huawei.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/core/fbcon.c