]> git.ipfire.org Git - thirdparty/libvirt.git/commit
src: report error from failing to add timer/FD watches
authorDaniel P. Berrangé <berrange@redhat.com>
Mon, 22 Jul 2024 14:56:03 +0000 (15:56 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Thu, 6 Nov 2025 12:04:48 +0000 (12:04 +0000)
commit878470256ee5498c972258b26748cc8cf5dc809d
tree13ab622acccca93a667ef51248b427ad7c93b984
parent9b7ef8058b18c7e90448b33664b25392fc600fee
src: report error from failing to add timer/FD watches

The virEventAddHandle/Timeout APIs are unusual in that they do not
report errors on failure, because they call through to function
callbacks which might be provided externally to libvirt and thus
won't be using libvirt's error reporting APIs.

This is a rather unfortunate design characteristic as we can see
most callers forgot about this special behaviour and so we are
lacking error reporting in many cases.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/libxl/libxl_driver.c
src/logging/log_cleaner.c
src/logging/log_handler.c
src/lxc/lxc_controller.c
src/node_device/node_device_udev.c
src/remote/remote_ssh_helper.c
src/rpc/virkeepalive.c
src/rpc/virnetclientstream.c
src/rpc/virnetserverclient.c
src/rpc/virnetserverservice.c