]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Report the correct is_temporary flag for column defaults.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 11 Sep 2025 21:11:54 +0000 (17:11 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 11 Sep 2025 21:11:54 +0000 (17:11 -0400)
commit8856f1acc97be5cc1816d42389c4a6852bc2ec86
tree06012705ac5e5460b25ad64b4b879a544dc1aa17
parent2915a8f8f2db0c9ece41877d46f4300730b4f7d7
Report the correct is_temporary flag for column defaults.

pg_event_trigger_dropped_objects() would report a column default
object with is_temporary = false, even if it belongs to a
temporary table.  This seems clearly wrong, so adjust it to
report the table's temp-ness.

While here, refactor EventTriggerSQLDropAddObject to make its
handling of namespace objects less messy and avoid duplication
of the schema-lookup code.  And add some explicit test coverage
of dropped-object reports for dependencies of temp tables.

Back-patch to v15.  The bug exists further back, but the
GetAttrDefaultColumnAddress function this patch depends on does not,
and it doesn't seem worth adjusting it to cope with the older code.

Author: Antoine Violin <violin.antuan@gmail.com>
Co-authored-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAFjUV9x3-hv0gihf+CtUc-1it0hh7Skp9iYFhMS7FJjtAeAptA@mail.gmail.com
Backpatch-through: 15
src/backend/commands/event_trigger.c
src/test/regress/expected/event_trigger.out
src/test/regress/sql/event_trigger.sql