]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
sched/rt: Skip group schedulable check with rt_group_sched=0
authorMichal Koutný <mkoutny@suse.com>
Mon, 23 Mar 2026 12:39:37 +0000 (13:39 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 8 Apr 2026 11:11:44 +0000 (13:11 +0200)
commit8b016dcec9365675be81d26be88f2c09cf983bd4
tree333df560af9289255d661b1a2ca10ffaee7014eb
parent556146ce5e9476db234134c46ddf0e154ca17028
sched/rt: Skip group schedulable check with rt_group_sched=0

The warning from the commit 87f1fb77d87a6 ("sched: Add RT_GROUP WARN
checks for non-root task_groups") is wrong -- it assumes that only
task_groups with rt_rq are traversed, however, the schedulability check
would iterate all task_groups even when rt_group_sched=0 is disabled at
boot time but some non-root task_groups exist.

The schedulability check is supposed to validate:
  a) that children don't overcommit its parent,
  b) no RT task group overcommits global RT limit.
but with rt_group_sched=0 there is no (non-trivial) hierarchy of RT groups,
therefore skip the validation altogether. Otherwise, writes to the
global sched_rt_runtime_us knob will be rejected with incorrect
validation error.

This fix is immaterial with CONFIG_RT_GROUP_SCHED=n.

Fixes: 87f1fb77d87a6 ("sched: Add RT_GROUP WARN checks for non-root task_groups")
Signed-off-by: Michal Koutný <mkoutny@suse.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20260323-sched-rert_groups-v3-1-1e7d5ed6b249@suse.com
kernel/sched/rt.c