]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
HID: logitech-dj: fix wrong detection of bad DJ_SHORT output report
authorBenjamin Tissoires <bentiss@kernel.org>
Fri, 10 Apr 2026 14:03:07 +0000 (16:03 +0200)
committerJiri Kosina <jkosina@suse.com>
Fri, 10 Apr 2026 15:23:02 +0000 (17:23 +0200)
commit8b9a097eb2fc37b486afd81388c693bf3ab44466
treeccd42c9d3daa11f31b6bdb15b514b2fdb939424c
parente2aaf2d3ad92ac4a8afa6b69ad4c38e7747d3d6e
HID: logitech-dj: fix wrong detection of bad DJ_SHORT output report

commit b6a57912854e ("HID: logitech-dj: Prevent REPORT_ID_DJ_SHORT
related user initiated OOB write") assumed that all HID devices attached
to the logitech-dj driver was having an output report of DJ_SHORT.

However, on the receiver itself, we have 2 other HID device we attach
here: the mouse emulation and the keyboard emulation. For those devices
the value of rep is NULL and we are triggered a segfault here.

This is doubly required because logitech-dj also handles non DJ devices
that might not have the DJ collection.

Fixes: b6a57912854e ("HID: logitech-dj: Prevent REPORT_ID_DJ_SHORT related user initiated OOB write")
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-logitech-dj.c